[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: add method addIconAction(QAction*, ActionCorner)
From: Alessandro Diaferia <alediaferia () gmail ! com>
Date: 2009-02-28 9:52:39
Message-ID: 65627f3a0902280152m2bb0ffb3hc7a79efecebffb26 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Sorry for the late reply.. i think i'll remove this patch from reviewboard..
Anyway i'd like to know a method to put the action at a specified corner
since youu suggested me to put the action of the devicenotifier refactoring
at the topright corner instead of the top left one.. Since trying to pass an
ampty action doesn't work i thought this patch would have been fine, but
didn't think about what you have just noriced :). So pleas, suggest me a way
or a workaround to put the action at the corner i choose..
2009/2/23 Aaron Seigo <aseigo@kde.org>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/14/#review245
> -----------------------------------------------------------
>
>
> so the reason i didn't expose the corner enum was so that we weren't stuck
> showing the icon in a specific location (e.g. the corner) of the icon. what
> if we wanted to show it in a circle around the icon, for instance? or on an
> overlay when you hover the icon (probably based on the form factor and size
> of the widget)? by exposing "this is the corner it will be in", we either
> lock ourselves into a single representation or set ourselves up for an API
> that doesn't really do what you tell it to but does "something else" with
> your input.
>
> so ... what exactly is the use case you are after here? i know you said
> something about the device notifier, but what's the exact end result you are
> going for?
>
>
> trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp
> <http://reviewboard.kde.org/r/14/#comment137>
>
> if there is a public enum, then IconWidgetPrivate::ActionPosition should
> simply be removed and IconwWidget::ActionCorner be used.
>
>
>
> trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp
> <http://reviewboard.kde.org/r/14/#comment138>
>
> this foreach really ought to be re-written to use a QMutableMapIterator;
> rather more efficient than what this is.
>
>
>
> trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp
> <http://reviewboard.kde.org/r/14/#comment140>
>
> should be changed to use a QMapIterator
>
>
> - Aaron
>
>
> On 2009-02-04 10:26:49, Alessandro Diaferia wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/14/
> > -----------------------------------------------------------
> >
> > (Updated 2009-02-04 10:26:49)
> >
> >
> > Review request for Plasma, Aaron Seigo and Marco Martin.
> >
> >
> > Summary
> > -------
> >
> > This patch adds the chance to specify in which corner the action will be
> placed. Useful for me in the devicenotifier refactor. In addition to this
> i've fixed the fact that the action is painted on the *widget*'s corner and
> not on the *icon*'s corner. To achieve this i used a workaround, but i don't
> like it much even if it correctly does the trick.
> >
> > I hope that everything is still BC.
> >
> > Lemme know what you think about this.
> >
> > Cheers :)
> >
> >
> > Diffs
> > -----
> >
> > trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 920669
> > trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 920669
> > trunk/KDE/kdelibs/plasma/widgets/iconwidget_p.h 920669
> >
> > Diff: http://reviewboard.kde.org/r/14/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Alessandro
> >
> >
>
>
--
Alessandro Diaferia
KDE Developer
[Attachment #5 (text/html)]
Sorry for the late reply.. i think i'll remove this patch from reviewboard.. \
Anyway i'd like to know a method to put the action at a specified corner since \
youu suggested me to put the action of the devicenotifier refactoring at the topright \
corner instead of the top left one.. Since trying to pass an ampty action doesn't \
work i thought this patch would have been fine, but didn't think about what you \
have just noriced :). So pleas, suggest me a way or a workaround to put the action at \
the corner i choose..<br> <br><div class="gmail_quote">2009/2/23 Aaron Seigo <span \
dir="ltr"><<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
</div><a href="http://reviewboard.kde.org/r/14/#review245" \
target="_blank">http://reviewboard.kde.org/r/14/#review245</a><br>
-----------------------------------------------------------<br>
<br>
<br>
so the reason i didn't expose the corner enum was so that we weren't stuck \
showing the icon in a specific location (e.g. the corner) of the icon. what if we \
wanted to show it in a circle around the icon, for instance? or on an overlay when \
you hover the icon (probably based on the form factor and size of the widget)? by \
exposing "this is the corner it will be in", we either lock ourselves into \
a single representation or set ourselves up for an API that doesn't really do \
what you tell it to but does "something else" with your input.<br>
<br>
so ... what exactly is the use case you are after here? i know you said something \
about the device notifier, but what's the exact end result you are going for?<br> \
<div class="Ih2E3d"><br> <br>
trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp<br>
</div><<a href="http://reviewboard.kde.org/r/14/#comment137" \
target="_blank">http://reviewboard.kde.org/r/14/#comment137</a>><br> <br>
if there is a public enum, then IconWidgetPrivate::ActionPosition should simply \
be removed and IconwWidget::ActionCorner be used.<br> <div class="Ih2E3d"><br>
<br>
<br>
trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp<br>
</div><<a href="http://reviewboard.kde.org/r/14/#comment138" \
target="_blank">http://reviewboard.kde.org/r/14/#comment138</a>><br> <br>
this foreach really ought to be re-written to use a QMutableMapIterator; rather \
more efficient than what this is.<br> <div class="Ih2E3d"><br>
<br>
<br>
trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp<br>
</div><<a href="http://reviewboard.kde.org/r/14/#comment140" \
target="_blank">http://reviewboard.kde.org/r/14/#comment140</a>><br> <br>
should be changed to use a QMapIterator<br>
<br>
<br>
- Aaron<br>
<div class="Ih2E3d"><br>
<br>
On 2009-02-04 10:26:49, Alessandro Diaferia wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/14/" \
target="_blank">http://reviewboard.kde.org/r/14/</a><br> > \
-----------------------------------------------------------<br> ><br>
</div>> (Updated 2009-02-04 10:26:49)<br>
<div class="Ih2E3d">><br>
><br>
> Review request for Plasma, Aaron Seigo and Marco Martin.<br>
><br>
><br>
</div><div class="Ih2E3d">> Summary<br>
> -------<br>
><br>
> This patch adds the chance to specify in which corner the action will be placed. \
Useful for me in the devicenotifier refactor. In addition to this i've fixed the \
fact that the action is painted on the *widget*'s corner and not on the \
*icon*'s corner. To achieve this i used a workaround, but i don't like it \
much even if it correctly does the trick.<br>
><br>
> I hope that everything is still BC.<br>
><br>
> Lemme know what you think about this.<br>
><br>
> Cheers :)<br>
><br>
><br>
> Diffs<br>
</div><div><div></div><div class="Wj3C7c">> -----<br>
><br>
> trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 920669<br>
> trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 920669<br>
> trunk/KDE/kdelibs/plasma/widgets/iconwidget_p.h 920669<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/14/diff" \
target="_blank">http://reviewboard.kde.org/r/14/diff</a><br> ><br>
><br>
> Testing<br>
> -------<br>
><br>
><br>
> Thanks,<br>
><br>
> Alessandro<br>
><br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Alessandro \
Diaferia<br>KDE Developer<br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic