[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Comic applet using Plasma::Widgets
From:       "Matthias Fuchs" <mat69 () gmx ! net>
Date:       2009-02-25 12:34:58
Message-ID: 20090225123458.16195.71132 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/145/
-----------------------------------------------------------

(Updated 2009-02-25 04:34:58.634432)


Review request for Plasma.


Changes
-------

The applet is working fine. Should I commit?


Summary (updated)
-------

I converted the comic applet to use Plasma::Widgets and basically everything works \
nice.

I have some questions though:

* Is there a way to avoid recreating the layout (ComicApplet::createLayout() in this \
                case )?
* Is there a way to add SpacerItems, so that mLabelId would be on the left of \
bottomLayout and only use as much space as needed, while mLabelUrl would be on the \
right and only use as much space needed as well?


Diffs (updated)
-----

  KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 930543 
  KDE/kdeplasma-addons/applets/comic/arrowwidget.h PRE-CREATION 
  KDE/kdeplasma-addons/applets/comic/arrowwidget.cpp PRE-CREATION 
  KDE/kdeplasma-addons/applets/comic/comic.h 930543 
  KDE/kdeplasma-addons/applets/comic/comic.cpp 930543 
  KDE/kdeplasma-addons/applets/comic/imagewidget.h PRE-CREATION 
  KDE/kdeplasma-addons/applets/comic/imagewidget.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/145/diff


Testing (updated)
-------

Works fine.


Thanks,

Matthias

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]