[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Let PopupApplet show BusyWidget in popup
From: "Marco Martin" <notmart () gmail ! com>
Date: 2009-02-25 8:58:04
Message-ID: 20090225085804.11409.53521 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/177/#review260
-----------------------------------------------------------
that's a god thing.
however, does it react to applet resize when is in a popup?
looking at it it remembers me that i must do a similar thing with config overlays, \
perhaps the busy widget could be put in a massage overlay an let a layout manage it, \
so the work would be done a single time? just a random idea
- Marco
On 2009-02-24 17:49:06, Artur de Souza (MoRpHeUz) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/177/
> -----------------------------------------------------------
>
> (Updated 2009-02-24 17:49:06)
>
>
> Review request for Plasma and Aaron Seigo.
>
>
> Summary
> -------
>
> Right now, PopupApplet can't show BusyWidget because it uses the applet's \
> boundingRect. To make it work inside the popup of PopupApplet, we need to change \
> some code inside Plasma::Applet to test if we have popup and if this is true, if we \
> should use widget() or graphicsWidget().
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/applet.cpp 929009
>
> Diff: http://reviewboard.kde.org/r/177/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> busywidget
> http://reviewboard.kde.org/r/177/s/30/
>
>
> Thanks,
>
> Artur
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic