[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make web shortcut icons look better in krunner
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2009-02-23 19:23:53
Message-ID: 20090223192353.4595.18772 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/47/#review247
-----------------------------------------------------------
Ship it!
i can't see the diff (rb seems to have messed it up) but the idea is sane.
- Aaron
On 2009-02-09 16:45:10, Michael Pyne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/47/
> -----------------------------------------------------------
>
> (Updated 2009-02-09 16:45:10)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Right now the icons on some web shortcut searches look poor, (for instance, our \
> love kde: shortcut gives me a question mark icon). I see that there is code to \
> give a sane default for icons with no favicon, but it doesn't seem to work here. \
> Using the kdelibs KMimeType instead of direct DBus calls seems to fix that.
> In addition since most favicons are small and look poor scaled up by the runner, I \
> added the ability to obey the Icon= setting of the .desktop files defining a web \
> shortcut. (For instance, try adding Icon=kde to the kde.desktop file in \
> kdebase/runtime/kurifilter-plugins/ikws/searchproviders or installed at \
> `kde4-config --install services`/searchproviders/kde.desktop. Now you get the very \
> nice glassy KDE logo when you type kde:KFoo in krunner).
>
> Diffs
> -----
>
> kdebase/workspace/plasma/runners/webshortcuts/webshortcutrunner.cpp 923467
>
> Diff: http://reviewboard.kde.org/r/47/diff
>
>
> Testing
> -------
>
> I've tested gg: (which has a favicon), kde: (whose Icon= overrides) and imdb: (no \
> favicon, nice default used instead of the question mark).
>
> Screenshots
> -----------
>
> How icons look with .desktop support
> http://reviewboard.kde.org/r/47/s/4/
> Sites with favicons
> http://reviewboard.kde.org/r/47/s/5/
> Sites without favicons
> http://reviewboard.kde.org/r/47/s/6/
> Just noticed that dragging the KRunner gives a different icon with this patch \
> though :( http://reviewboard.kde.org/r/47/s/7/
>
>
> Thanks,
>
> Michael
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic