[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: bisecting the 1-pixel bug
From: Alexis_Ménard <menard () kde ! org>
Date: 2009-02-16 17:12:26
Message-ID: 81941aea0902160912i735800efm1020355b161495b1 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi,
This is fixed, i will have the review tomorrow and i will push it for 4.5.0
final.
But to be sure it works you have to clean the cache in your
.kde4/cache-*/kpc/plasma*
Otherwise it won't redraw all svgs without the 1 px bug.
On Sat, Feb 14, 2009 at 5:33 PM, Alexis M=E9nard <menard@kde.org> wrote:
> Ok thanks for taking time...we are still on it...Monday i will take a loo=
k
> on it and provide that to our graphics team.
>
> 2009/2/14 Marco Martin <notmart@gmail.com>
>
>> Hi all,
>> before i forget the details, i've done some tests about the 1 pixel bug =
in
>> framesvg and what i found is this:
>> it happens only when the svgrenderer paints on a qpixmap, if asked to
>> paint on
>> all of it, sometimes the last pixel gets not painted, the minimum amount
>> of
>> code to reliably cause this is the file attached, note the 1 pixel red
>> line
>> that appears sometimes.
>>
>> i've done a git bisect on the qt/all snapshot branch and probably doesn'=
t
>> tell
>> that much (it does just reflet snapshots and not actual commits right?)
>> but what i've found, if i didn't did terrible mistakes is that:
>>
>> (if it's not a really trivial thing to fix i'm going to post this on the
>> qt
>> task tracker)
>>
>> 355c90dad265a6c3b20f7bffeeabdc420ace78ee is first bad commit
>> commit 355c90dad265a6c3b20f7bffeeabdc420ace78ee
>> Author: Snapshots <snapshots@trolltech.com>
>> Date: Wed Dec 3 02:00:16 2008 +0100
>>
>> Update to Qt 4.5 snapshot 20081203
>>
>> :100644 100644 f053d8e7342aa99764f9f4674296d9ca9a4db372
>> 8a9943da9b00c055f7d8dd5ebaffe0698c9502b4 M .tag
>> :040000 040000 24d96e05510c648058db5df5b5ef2bbad15f82c9
>> 7961db773e9b5b60ec300edbddcc87998d1c068b M doc
>> :040000 040000 60df8b9737bcb54961c379640241c725963dee04
>> 7d3f9d1080034f16a11fc1a7caf0d581a59ed4a9 M qmake
>> :040000 040000 f89dd3fb8c536d65c8a0f091807c0a61030b4f59
>> ded3aa6cdf7bec61efad821e255565a07c39452b M src
>> :040000 040000 6edf3b7029b91891f30295e21e49f9a6c1380159
>> 20fa707790f7a3d935642e39ac7561832d9692c7 M tools
>>
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>>
>
[Attachment #5 (text/html)]
Hi,<br><br>This is fixed, i will have the review tomorrow and i will push it for \
4.5.0 final.<br><br>But to be sure it works you have to clean the cache in your \
.kde4/cache-*/kpc/plasma*<br><br>Otherwise it won't redraw all svgs without the 1 \
px bug.<br> <br><div class="gmail_quote">On Sat, Feb 14, 2009 at 5:33 PM, Alexis \
Ménard <span dir="ltr"><<a \
href="mailto:menard@kde.org">menard@kde.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> Ok thanks for taking time...we are still on \
it...Monday i will take a look on it and provide that to our graphics \
team.<br><br><div class="gmail_quote">2009/2/14 Marco Martin <span dir="ltr"><<a \
href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="Wj3C7c">Hi \
all,<br> before i forget the details, i've done some tests about the 1 pixel bug \
in<br> framesvg and what i found is this:<br>
it happens only when the svgrenderer paints on a qpixmap, if asked to paint on<br>
all of it, sometimes the last pixel gets not painted, the minimum amount of<br>
code to reliably cause this is the file attached, note the 1 pixel red line<br>
that appears sometimes.<br>
<br>
i've done a git bisect on the qt/all snapshot branch and probably doesn't \
tell<br> that much (it does just reflet snapshots and not actual commits right?)<br>
but what i've found, if i didn't did terrible mistakes is that:<br>
<br>
(if it's not a really trivial thing to fix i'm going to post this on the \
qt<br> task tracker)<br>
<br>
355c90dad265a6c3b20f7bffeeabdc420ace78ee is first bad commit<br>
commit 355c90dad265a6c3b20f7bffeeabdc420ace78ee<br>
Author: Snapshots <<a href="mailto:snapshots@trolltech.com" \
target="_blank">snapshots@trolltech.com</a>><br>
Date: Wed Dec 3 02:00:16 2008 +0100<br>
<br>
Update to Qt 4.5 snapshot 20081203<br>
<br>
> 100644 100644 f053d8e7342aa99764f9f4674296d9ca9a4db372<br>
8a9943da9b00c055f7d8dd5ebaffe0698c9502b4 M .tag<br>
> 040000 040000 24d96e05510c648058db5df5b5ef2bbad15f82c9<br>
7961db773e9b5b60ec300edbddcc87998d1c068b M doc<br>
> 040000 040000 60df8b9737bcb54961c379640241c725963dee04<br>
7d3f9d1080034f16a11fc1a7caf0d581a59ed4a9 M qmake<br>
> 040000 040000 f89dd3fb8c536d65c8a0f091807c0a61030b4f59<br>
ded3aa6cdf7bec61efad821e255565a07c39452b M src<br>
> 040000 040000 6edf3b7029b91891f30295e21e49f9a6c1380159<br>
20fa707790f7a3d935642e39ac7561832d9692c7 M tools<br>
<br></div></div>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org" target="_blank">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br> </blockquote></div><br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic