[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: add method addIconAction(QAction*,
From:       "Alessandro Diaferia" <alediaferia () gmail ! com>
Date:       2009-02-04 13:44:16
Message-ID: 20090204134416.18838.85158 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/14/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and Marco Martin.


Summary
-------

This patch adds the chance to specify in which corner the action will be placed. \
Useful for me in the devicenotifier refactor. In addition to this i've fixed the fact \
that the action is painted on the *widget*'s corner and not on the *icon*'s corner. \
To achieve this i used a workaround, but i don't like it much even if it correctly \
does the trick.

I hope that everything is still BC.

Lemme know what you think about this.

Cheers :)


Diffs
-----

  trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 920669 
  trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 920669 
  trunk/KDE/kdelibs/plasma/widgets/iconwidget_p.h 920669 

Diff: http://reviewboard.kde.org/r/14/diff


Testing
-------


Thanks,

Alessandro

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]