[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [PATCH] Multiscreen fix!
From: Alessandro Diaferia <alediaferia () gmail ! com>
Date: 2009-02-01 14:47:28
Message-ID: 65627f3a0902010647n628138c4yd927859ad2b8d7dd () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2009/2/1 Guillaume Pothier <gpothier@gmail.com>
> 2009/2/1 Alessandro Diaferia <alediaferia@gmail.com>:
> > I deeply checked and Kephal actually returns correct screen info (2
> > screens,
> > the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)).
> Moreover
> > adjustSize() uses Plasma::View::screen()
> > in order to resize the view, and before delaying adjustSize, that
> screen
> > was just wrong.
>
> Ok, so if Kephal reports the correct sizes then you most likely have
> xrandr1.2, and so you are right, it's another problem. So I agree with
> your patch now :-)
Yeah, i have xrandr-1.2.3 :D
>
> Cheers,
> g
>
Regards
>
>
> >
> >>
> >> I actually had a patch to fix this but I was waiting for somebody to
> >> test it before committing. Can you check this bug:
> >> http://bugs.kde.org/show_bug.cgi?id=181325 and test the patch,
> >> reverting your own patch, and see if it works for you?
> >
> > It does not do me the trick.. I still have second screen displacement..
> I
> > feel the issues are not correlated, anyway i'd wait for
> > someone else, more expert than me, to talk :)
> >
> >>
> >> Cheers,
> >> g
> >
> > Cheers :)
> >
> >>
> >> 2009/1/30 Alessandro Diaferia <alediaferia@gmail.com>:
> >> > As you can see from the sources Plasma::View uses
> QTimer::singleShot(0,
> >> > this, SLOT(privateInit())) in the ctor but DesktopView calls
> >> > adjustSize() in
> >> > the ctor with no delay..
> >> >
> >> > This causes the fact that adjustSize() uses invalid information about
> >> > the
> >> > current screen to setup its size and makes my second screen disappear
> >> > (or
> >> > actually, with a wrong size/position).
> >> > I managed to fix this giving a delay also to adjustSize() so that when
> >> > it is
> >> > called the correct information are already set (and screen() returns
> the
> >> > correct number in this case).
> >> >
> >> > Hope this is ok to commit, since i'd like to have my screen back
> >> > officially
> >> > :P
> >> >
> >> > Since i'm having troubles with the reviewboard here comes the patch:
> >> >
> >> > Index: shells/desktop/desktopview.cpp
> >> > ===================================================================
> >> >
> >> > --- shells/desktop/desktopview.cpp (revision 918687)
> >> > +++ shells/desktop/desktopview.cpp (working copy)
> >> > @@ -104,7 +104,7 @@ DesktopView::DesktopView(Plasma::Contain
> >> > QBrush b(tile);
> >> > setBackgroundBrush(tile);
> >> >
> >> >
> >> > - adjustSize();
> >> > + QTimer::singleShot(0, this, SLOT(adjustSize()));
> >> >
> >> > Kephal::Screens *screens = Kephal::Screens::self();
> >> > connect(screens, SIGNAL(screenResized(Kephal::Screen *, QSize,
> >> > QSize)),
> >> >
> >> >
> >> > Hugs!!
> >> >
> >> > --
> >> > Alessandro Diaferia
> >> >
> >> > _______________________________________________
> >> > Plasma-devel mailing list
> >> > Plasma-devel@kde.org
> >> > https://mail.kde.org/mailman/listinfo/plasma-devel
> >> >
> >> >
> >> _______________________________________________
> >> Plasma-devel mailing list
> >> Plasma-devel@kde.org
> >> https://mail.kde.org/mailman/listinfo/plasma-devel
> >
> >
> >
> > --
> > Alessandro Diaferia
> >
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
> >
> >
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
--
Alessandro Diaferia
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">2009/2/1 Guillaume Pothier <span dir="ltr"><<a \
href="mailto:gpothier@gmail.com">gpothier@gmail.com</a>></span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> 2009/2/1 Alessandro Diaferia <<a \
href="mailto:alediaferia@gmail.com">alediaferia@gmail.com</a>>:<br> <div \
class="Ih2E3d">> I deeply checked and Kephal actually returns correct \
screen info (2<br> > screens,<br>
> the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). \
Moreover<br> > adjustSize() uses Plasma::View::screen()<br>
> in order to resize the view, and before delaying adjustSize, that \
screen<br> > was just wrong.<br>
<br>
</div>Ok, so if Kephal reports the correct sizes then you most likely have<br>
xrandr1.2, and so you are right, it's another problem. So I agree with<br>
your patch now :-)</blockquote><div><br>Yeah, i have xrandr-1.2.3 :D \
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br> Cheers,<br>
<div><div></div><div class="Wj3C7c">g</div></div></blockquote><div><br>Regards \
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div> <div class="Wj3C7c"><br>
<br>
><br>
>><br>
>> I actually had a patch to fix this but I was waiting for somebody to<br>
>> test it before committing. Can you check this bug:<br>
>> <a href="http://bugs.kde.org/show_bug.cgi?id=181325" \
target="_blank">http://bugs.kde.org/show_bug.cgi?id=181325</a> and test the \
patch,<br> >> reverting your own patch, and see if it works for you?<br>
><br>
> It does not do me the trick.. I still have second screen displacement.. \
I<br> > feel the issues are not correlated, anyway i'd wait for<br>
> someone else, more expert than me, to talk :)<br>
><br>
>><br>
>> Cheers,<br>
>> g<br>
><br>
> Cheers :)<br>
><br>
>><br>
>> 2009/1/30 Alessandro Diaferia <<a \
href="mailto:alediaferia@gmail.com">alediaferia@gmail.com</a>>:<br> >> > \
As you can see from the sources Plasma::View uses QTimer::singleShot(0,<br> >> \
> this, SLOT(privateInit())) in the ctor but DesktopView calls<br> >> > \
adjustSize() in<br> >> > the ctor with no delay..<br>
>> ><br>
>> > This causes the fact that adjustSize() uses invalid information \
about<br> >> > the<br>
>> > current screen to setup its size and makes my second screen \
disappear<br> >> > (or<br>
>> > actually, with a wrong size/position).<br>
>> > I managed to fix this giving a delay also to adjustSize() so that \
when<br> >> > it is<br>
>> > called the correct information are already set (and screen() returns \
the<br> >> > correct number in this case).<br>
>> ><br>
>> > Hope this is ok to commit, since i'd like to have my screen \
back<br> >> > officially<br>
>> > :P<br>
>> ><br>
>> > Since i'm having troubles with the reviewboard here comes the \
patch:<br> >> ><br>
>> > Index: shells/desktop/desktopview.cpp<br>
>> > ===================================================================<br>
>> ><br>
>> > --- shells/desktop/desktopview.cpp (revision 918687)<br>
>> > +++ shells/desktop/desktopview.cpp (working copy)<br>
>> > @@ -104,7 +104,7 @@ DesktopView::DesktopView(Plasma::Contain<br>
>> > QBrush b(tile);<br>
>> > setBackgroundBrush(tile);<br>
>> ><br>
>> ><br>
>> > - adjustSize();<br>
>> > + QTimer::singleShot(0, this, SLOT(adjustSize()));<br>
>> ><br>
>> > Kephal::Screens *screens = \
Kephal::Screens::self();<br> >> > connect(screens, \
SIGNAL(screenResized(Kephal::Screen *, QSize,<br> >> > QSize)),<br>
>> ><br>
>> ><br>
>> > Hugs!!<br>
>> ><br>
>> > --<br>
>> > Alessandro Diaferia<br>
>> ><br>
>> > _______________________________________________<br>
>> > Plasma-devel mailing list<br>
>> > <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
>> > <a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> >> \
><br> >> ><br>
>> _______________________________________________<br>
>> Plasma-devel mailing list<br>
>> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
>> <a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> ><br>
><br>
><br>
> --<br>
> Alessandro Diaferia<br>
><br>
> _______________________________________________<br>
> Plasma-devel mailing list<br>
> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> ><br>
><br>
_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Alessandro Diaferia<br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic