[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: KDE/kdelibs/plasma
From:       Dan Meltzer <parallelgrapefruit () gmail ! com>
Date:       2009-01-28 0:19:22
Message-ID: 46059ce10901271619x6ae3b5dah8809d7be3ceca7c8 () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jan 27, 2009 at 7:12 PM, Christophe Giboudeaux
<cgiboudeaux@gmail.com> wrote:
> SVN commit 917529 by cgiboudeaux:
>
> kaction.h is already included. Just remove the extra ones

Would it make sense, in terms of visual helpers--to not use camelcase
for qt includes in kdelibs/plasma as well? I have a feeling that this
would provide a style hint, as well as a reminder, to people about
using "standard" includes.  Looking quickly at CamelCase qt includes
provides a hint that they are acceptable, and might carry over into
kde includes.. which arn't.
>
>  M  +0 -1      applet.cpp
>  M  +0 -1      containment.cpp
>
>
> --- trunk/KDE/kdelibs/plasma/applet.cpp #917528:917529
> @@ -25,7 +25,6 @@
>  #include <cmath>
>  #include <limits>
>
> -#include <kaction.h>
>  #include <QApplication>
>  #include <QEvent>
>  #include <QFile>
> --- trunk/KDE/kdelibs/plasma/containment.cpp #917528:917529
> @@ -21,7 +21,6 @@
>  #include "containment.h"
>  #include "private/containment_p.h"
>
> -#include <kaction.h>
>  #include <QFile>
>  #include <QGraphicsSceneContextMenuEvent>
>  #include <QGraphicsView>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]