[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Auto unhide panel when stuff in it gets activated
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2009-01-23 11:52:30
Message-ID: 20090123115230.17958.8373 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/341/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This makes an hidden panel auto unhide when the panel containment emits activated(), \
the concept is that if an applet in it gets activated it probably has focus so would \
need keyboard input, is requesting user attention etc. for instance it would make \
easy for the taskbar to auto unhide the panel when a task wants attention. now i'm \
not sure whete this is located in the balance convenience/annoyance, but seemed a \
sensible idea...

it also need a patch to applet.cpp

Index: applet.cpp
===================================================================
--- applet.cpp  (revision 915223)
+++ applet.cpp  (working copy)
@@ -1178,6 +1267,7 @@
         d->activationAction->setObjectName(QString("activate widget %1").arg(id())); \
                // NO I18N
         connect(d->activationAction, SIGNAL(triggered()), this, SIGNAL(activate()));
         connect(this, SIGNAL(activate()), this, SLOT(setFocus()));
+        connect(this, SIGNAL(activate()), containment, SIGNAL(activate()));     

         QList<QWidget *> widgets = d->actions.associatedWidgets();
         foreach (QWidget *w, widgets) {

that forwards activate of applets to activate of the containment
yeah i know should checkout whole trunk/KDE so patches would be more decent, my bad \
:p


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp

Diff: http://reviewboard.vidsolbach.de/r/341/diff


Testing
-------


Thanks,

Marco

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]