[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] fix for 6 krazy2 issues
From:       Dan Meltzer <parallelgrapefruit () gmail ! com>
Date:       2009-01-22 14:54:37
Message-ID: 46059ce10901220654x6e6e6fd3l5fdfb87d8e7a12a9 () mail ! gmail ! com
[Download RAW message or body]

2009/1/22 Bruno Bigras <bruno@burnbox.net>:
> Comments would be appreciated, especially for the foreach patch.

* Qt::SizeHint is an enum, there is no need to use const references
with it (it shuold probably be ignored in krazy proper)

in 5_strings.diff I don't think that explicity wrapping literals in
QString is necessary...  but ebn is down so I can't see why it
suggests that.

Dan,
>
> apply in kdeplasma-addons/applets
>
> Thanks!
>
> Bruno
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]