[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Auto scroll in kickoff
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-01-18 3:06:42
Message-ID: 13ed09c00901171906x263be635x29d0fd34d6d25787 () mail ! gmail ! com
[Download RAW message or body]

Hi,

I cannot comment on the idea itself yet but with regards to the code,
there is duplication of code and constants to implement this in UrlItemView and
FlipScrollView.  This should be avoided if possible because it is
likely in future that
some changes might need to be made to the behavior and the implementations
may get out of sync.

Regards,
Robert.

2009/1/17 Andras Keri <andras.ker@freemail.hu>:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/333/
> -----------------------------------------------------------
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch allows auto scroll in kickoff which could be handy in the case of long \
> lists. The auto scroll is triggered if the mouse is in the outer half of the \
> top/bottom visible item. 
> Two things to note:
> - the speed may be not ideal, should be a bit slower,
> - the auto scroll in the case of drag and drop works differently, that could be \
> confusing. 
> Any comments, suggestions are more than welcome.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/urlitemview.cpp
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/urlitemview.h
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/flipscrollview.h
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/flipscrollview.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/333/diff
> 
> 
> Testing
> -------
> 
> On local machine.
> 
> 
> Thanks,
> 
> Andras
> 
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
> 
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]