[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Make Knotify show the icon and the name of the
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-01-06 1:05:35
Message-ID: 20090106010535.27426.53125 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/323/#review311
-----------------------------------------------------------

Ship it!


this is also how the old popups work, so that's good.

in future we may want to provide a fallback to an app icon if there is no icon in the \
config .. but that's something for the future, this should be in 4.2.

- Aaron


On 2009-01-05 16:38:20, Loic Marteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/323/
> -----------------------------------------------------------
> 
> (Updated 2009-01-05 16:38:20)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hey,
> 
> This patch make the notification in systray show correctly the icon for apps like \
> powerdevil because the name of their icon is not the same of the name of the app. \
> The icon and the caption of the application comes now from the notifyrc file. 
> Cheers
> 
> Lo
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/runtime/knotify/notifybypopup.h
> /trunk/KDE/kdebase/runtime/knotify/notifybypopup.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/323/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Loic
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]