Aaron J. Seigo wrote:
> On Friday 02 January 2009, Dotan Cohen wrote:
>> Due to disability, I cannot move to KDE 4.x until this issue is resolved:
>> http://bugs.kde.org/show_bug.cgi?id=165402
>>
>> I have spoken with the developer and he is confident that the applet
>> is ready to move from review to plasma-addons, someone just needs to
> 
> i'm confident it isn't. ;)
> 
> first, the applet belong in kdebase/workspace imho. a11y isn't an "add
> on", it needs to be part of the core package.

+n where n>0 :)
 
the todo;
 
> * it creates it's own KIconLoader on line 82

KIconLoader::global() ?

> * it uses pixmaps in the icon theme for the buttons; this probably made
> sense when the code that was ported to make this applet was written. these
> days it should be using an SVG. this is one of the reasons it doesn't
> scale properly, which is ironic for an a11y tool.

will look

> * it doesn't use Plasma::Theme (see line 141)

will look
 
> etc...

What etc?

> it needs work, but it just got moved into kdereview and nobody's 
> really said anything about it to anyone since.

yay, I was still waiting for feedback for 
http://mail.kde.org/pipermail/plasma-devel/2008-October/001962.html which 
seems to come in now ;)

> whoever is working on it 
> these days ought to come into #plasma or find us on plasma-devel@kde.org
> and work these issues out,

Gimme details... are there more issues? iirc Michael Leupold already asked a 
while back if we should/would like to turn the logic into a reusuable class 
for kdelibs. Probably we should/would also like to provide a dataengine for 
reuse?! or are the SVG+Theme issues noted above enough to be addressed to get 
it into kdebase?
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel