[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Don't use a custom scrollbar widget in the
From: "Marco Martin" <notmart () gmail ! com>
Date: 2008-12-23 19:52:23
Message-ID: 20081223195223.11390.84122 () localhost
[Download RAW message or body]
> On 2008-12-23 11:14:04, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp, line 46
> > <http://reviewboard.vidsolbach.de/r/313/diff/2/?file=1672#file1672line46>
> >
> > should this still be there?
haha, little whoopsie :)
> On 2008-12-23 11:14:04, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp, line 60
> > <http://reviewboard.vidsolbach.de/r/313/diff/2/?file=1672#file1672line60>
> >
> > looks like we need a setAlignment method in Plasma::Label? =)
ok, i can add the function right now
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/313/#review305
-----------------------------------------------------------
On 2008-12-23 10:01:25, Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/313/
> -----------------------------------------------------------
>
> (Updated 2008-12-23 10:01:25)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This makes the job viewer extenderitem in the systemtray to use just the standard \
> scrollbar widget instead of a custom one and layouts and plasma labels to display \
> the info. I think it's a pretty important thing to not make custom svg widget \
> proliferate, otherwise theming will become a real mess (a different scrollbar for \
> each possible label disposition would be really bad). and a thing like that should \
> be done like now or never :)
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.h
> /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/313/diff
>
>
> Testing
> -------
>
> tried to start some jobs, it seems to both look and behave in the exact way as \
> before
>
> Thanks,
>
> Marco
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic