[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: PATCH for improve the panel action(bug num:177219)
From:       Sebastian =?iso-8859-1?q?K=FCgler?= <sebas () kde ! org>
Date:       2008-12-12 16:44:54
Message-ID: 200812121744.55254.sebas () kde ! org
[Download RAW message or body]

On Monday 08 December 2008 13:40:37 zhangqiang wrote:
> In order to help general users.I make a patch.I don't know whether it is
> needed and suitable.That is, if the user deletes the last panel,give the
> tip "This is the last panel! Make sure you know how to add it.",that is
> unlike the usual tip "Do you really want to remove the panel ?" I do it in
> the containment, and my patch attached. Thanks very much.

Other than Aaron's comments, the codingstyle is not in accordance with what we 
usually do, tabs/spaces mix (it should always be 4 spaces), whitespace around 
parentheses.

Something to take care of in your next revision :)
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]