[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Bugfix for Folderview bug #175191
From:       Fredrik =?iso-8859-1?q?H=F6glund?= <fredrik () kde ! org>
Date:       2008-12-04 16:59:07
Message-ID: 200812041759.07394.fredrik () kde ! org
[Download RAW message or body]

On Sunday 30 November 2008 18:20, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/288/#review276
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> yes, that's probably sensible.
> 
> 
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
> <http://reviewboard.vidsolbach.de/r/288/#comment228>
> 
> i'm a little surprised that setUrl doesn't call dirListed()->openUrl or \
> updateIconWidget, but Frederik could probably explain why =)

I actually can't explain that because I didn't write that particular method ;)

But I think it's a bit of a misnomer because what it really does is update
the icon view label.

Regards,
Fredrik

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]