[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Bugfix for Folderview bug #175191
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-11-30 17:20:17
Message-ID: 20081130172017.4467.58338 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/288/#review276
-----------------------------------------------------------

Ship it!


yes, that's probably sensible.


/trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
<http://reviewboard.vidsolbach.de/r/288/#comment228>

    i'm a little surprised that setUrl doesn't call dirListed()->openUrl or \
updateIconWidget, but Frederik could probably explain why =)


- Aaron


On 2008-11-29 13:10:59, Jesse Zamora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/288/
> -----------------------------------------------------------
> 
> (Updated 2008-11-29 13:10:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch is my feeble attempt to fix bug #175191 \
> (https://bugs.kde.org/show_bug.cgi?id=175191). What it does is that if the user \
> accidentally removes the folder the folderview is pointing to, it then just reverts \
> to the home folder. Tell me what you all think about this, and please if you have \
> any suggestions, let me know! 
> Xtreme Kommander
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.h
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/288/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesse
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]