[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add support for custom package metadata
From:       Petri_Damstén <petri.damsten () gmail ! com>
Date:       2008-11-02 11:48:01
Message-ID: 20081102114801.27091.67222 () vidsolbach ! de
[Download RAW message or body]



> On 2008-11-02 03:33:56, Aaron Seigo wrote:
> > a little bit of cleanup needed yet, but generally ready to go in.
> > 
> > not sure what your use case was, though this is obviously useful (there was even \
> > a comment in there about it =) 

So plasmapkg can get pluginName for package and uninstall works also when package \
file name is given on command line (which is what we get from knewstuff2).


> On 2008-11-02 03:33:56, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp, lines 447-449
> > <http://reviewboard.vidsolbach.de/r/248/diff/4/?file=1337#file1337line447>
> > 
> > is that really needed?

Package seems to add '/' to the path also when it's a zip archive. Hmm maybe it \
should be fixed there.


- Petri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/248/#review242
-----------------------------------------------------------


On 2008-11-02 03:11:18, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/248/
> -----------------------------------------------------------
> 
> (Updated 2008-11-02 03:11:18)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This adds support for custom package metadata. 
> 
> Update:
> - Default metadata handling in PackageStructure
> - PackageStructure also returns Plasma::PackageMetadata (not a pointer)
> - Always get metadata from the PackageStructure. It creates it on demand.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/libs/plasma/package.cpp
> /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.h
> /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/248/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]