----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/247/#review239 ----------------------------------------------------------- Ship it! Looks fine to me. - Jason On 2008-10-31 06:42:16, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/247/ > ----------------------------------------------------------- > > (Updated 2008-10-31 06:42:16) > > > Review request for Plasma. > > > Summary > ------- > > this belongs to the efforts with nuno to make the theme better for 4.2:) > this is a little change in the system tray, now it still enable/disable margins based if there is enough room or not but always paints the background: since the icons background is still a fake transparency that not always work in the 4.2 theme there will be a fully opaque background (the solution that looks less wrong) with very little margin, so will look ok even if the margins are disabled. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp > > Diff: http://reviewboard.vidsolbach.de/r/247/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel