[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: removal of windowChangedGeomtetry signal
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-10-30 9:05:33
Message-ID: 20081030090533.7081.87606 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/246/#review238
-----------------------------------------------------------

Ship it!


- Marco


On 2008-10-29 17:20:18, Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/246/
> -----------------------------------------------------------
> 
> (Updated 2008-10-29 17:20:18)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> Remove the windowChangedGeomtetry signal from the TaskManager and use the new \
> itemChanged(item*, changes) signal. make it possible to turn of geometryTracking \
> after it was turned on once. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/246/diff
> 
> 
> Testing
> -------
> 
> tried out if the tracking is enabled when showOnlyCurrentScreen is enabled.
> haven't tried the actual mutlti screen stuff but i didn't change this code so it \
> should still work =) 
> 
> Thanks,
> 
> Christian
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]