[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Make sure that focused result item is visible
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-10-29 4:42:05
Message-ID: 20081029044205.9779.13626 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/245/#review237
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-10-26 16:13:07, Dmitry Suzdalev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/245/
> -----------------------------------------------------------
> 
> (Updated 2008-10-26 16:13:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch makes krunner's ResultScene correctly update current page when \
> navigating through items using Tab key. Without this patch it works correctly (i.e. \
> page is changed as user focuses some item on a next page) only if \
> Up/Down/Left/Right keys are pressed. As we can't catch Key_Tab in keyPressEvent, \
> we'll watch for item selection events. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/krunner/resultscene.h
> /trunk/KDE/kdebase/workspace/krunner/resultscene.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/245/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]