[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: plasma apps and screen information
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-10-27 23:02:47
Message-ID: 200810271702.47625.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 27 October 2008, Guillaume Pothier wrote:
> 2008/10/27 Aaron J. Seigo <aseigo@kde.org>:
> >> The latter should probably return a QRegion instead, according to what
> >> you said about toolbox placement.
> >
> > yes, it should be a QRegion.
>
> ok, I'll use QRegion in the API, but for now the region will be
> rectangular and the toolbox positioning code will rely on the region's
> bounding box. Later I'll see how to improve that. Is that ok?

absolutely. it's a good pragmatic "one step at a time" approach


> >> - Added a ViewerCorona class to plasmoidviewer, as Plasma::Corona is
> >> now has pure virtual methods.
> >
> > shouldn't be necessary if they aren't pure virtual. that you had to do
> > this work was probably a good hint something could be better =)
>
> I think plasmoidviewer needs its own corona anyway so as to report the
> actual window size instead of a meaningless value?

no; it should just set the sceneRect to be equal to the window size. i'm 
pretty sure it already does that, actually.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]