[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: tasks painting semplification
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-10-27 22:51:48
Message-ID: 200810271651.48686.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 27 October 2008, Jamboarder wrote:
> > From: Marco Martin <notmart@gmail.com>
> > aaanyways, the painting function it's really a mess because when i added
> > the support for svg theming i decided to add a fallback for every
> > element, so when it does not exist in the svg just paints a rounded
> > rectangle, so the code is 80% manual qpainter cruft.
> > now, would be interesting as a general rule how to behave in this cases,
> > i think that just removing the fallbackswould make way more cleaner code.
> > i kinda remember chatting with aaron on a similar situation (don't
> > remember what was the theme/plasmoid in particular) was decided to just
> > consider it a problem of who makes the theme to ensure all the elements
> > are in what do you guys think?
>
> As long as the default theme tasks.svg has the required elements, it should
> behave much the same as other theme elements: When the theme author omits
> the svg, use the default theme svg.  I'm all for doing away with the
> qpainter cruft.

+1

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]