[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: tasks painting semplification
From:       Jamboarder <jamboarder () yahoo ! com>
Date:       2008-10-27 16:08:33
Message-ID: 942533.7346.qm () web37308 ! mail ! mud ! yahoo ! com
[Download RAW message or body]

> From: Marco Martin <notmart@gmail.com>
> aaanyways, the painting function it's really a mess because when i added the 
> support for svg theming i decided to add a fallback for every element, so when 
> it does not exist in the svg just paints a rounded rectangle, so the code is 
> 80% manual qpainter cruft.
> now, would be interesting as a general rule how to behave in this cases, i 
> think that just removing the fallbackswould make way more cleaner code.
> i kinda remember chatting with aaron on a similar situation (don't remember 
> what was the theme/plasmoid in particular) was decided to just consider it a 
> problem of who makes the theme to ensure all the elements are in
> what do you guys think?
As long as the default theme tasks.svg has the required elements, it should behave much the \
same as other theme elements: When the theme author omits the svg, use the default theme svg.  \
I'm all for doing away with the qpainter cruft.

Hope this helps,
Andrew (Jamboarder) Lake
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]