[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: plasma apps and screen information
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2008-10-26 17:18:57
Message-ID: 200810261118.57878.aseigo () kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
On Sunday 26 October 2008, Guillaume Pothier wrote:
> On Fri, Oct 24, 2008 at 12:08 PM, Guillaume Pothier <gpothier@gmail.com>
wrote:
> > Ok, here comes the patch. In summary:
> > - Added three methods to Corona:
> > int numScreens()
> > QRect screenGeometry(int)
> > QRect availableScreenGeometry(int)
> > The latter should probably return a QRegion instead, according to what
> > you said about toolbox placement.
> > - QDesktopWidget is not used anymore in libplasma, entirely replaced
> > by calls to the new Corona methods.
> > - Added Corona* parameter to Plasma::popupPosition
> > - Added a corona() method to Plasma::Applet. This is needed for calls
> > to Plasma::popupPosition.
> > - Also added a corona() method to Plasma::View for consistency's sake.
> > - Corona is friends with ToolTipManager, as ToolTipManager needs to
> > call Plasma::popupPosition and thus needs a Corona. Thus, Corona
> > registers itself with the ToolTipManager. I think this is the ugliest
> > part of the patch, please tell me if there is a better solution.
> > - Added a ViewerCorona class to plasmoidviewer, as Plasma::Corona is
> > now has pure virtual methods.
> >
> > Ok to commit?
>
> Any comment about the patch?
not yet. i'm about to leave for the airport in about 2 hours and am busy
getting things together.
*sigh* here i'll quickly comment..
> Another thing: I noticed Lancelot instantiates a Plasma::Corona
> (LancelotWindow.cpp:205). That doesn't work anymore with my patch, as
> Corona has pure virtual methods.
they shouldn't be pure virtual. just given them meaningless defaults.
> Why is Lancelot instantiating its own corona?
no idea, but quite frankly that's broken.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
["signature.asc" (application/pgp-signature)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic