[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: new meter theming approach
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-10-25 10:57:04
Message-ID: 20081025105704.9339.81205 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/239/
-----------------------------------------------------------

(Updated 2008-10-25 03:57:03.852304)


Review request for Plasma.


Summary
-------

the old theming for Plasma::Meter deformed the bar way too much when it was resized \
too wide this uses panelsvg and tiling to do the image, and there is the new theme..
it should be retrocompatible with old themes, still falls back at the old elements

it does have a problem, when the number of tiles is not integer  it rounds to the \
lower integer and mover the progressbar pattern at the centr, so there are little \
margins at both sides. maybe not reeally pretty but still better than the deformed \
old one i think

now the ratio uses the active bar center element


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_horizontal.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_vertical.svgz

Diff: http://reviewboard.vidsolbach.de/r/239/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.vidsolbach.de/r/239/s/84/


Thanks,

Marco

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]