[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: big visual drop target when dropping applets on
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-10-20 13:07:51
Message-ID: 20081020130751.13631.41621 () vidsolbach ! de
[Download RAW message or body]



> On 2008-10-19 15:37:32, Aaron Seigo wrote:
> > should this be in plasma/shells/desktop/panelview.cpp? because then we can share \
> > the AppletMoveSpacer (for consistent visualization) and this will work with any \
> > panel that uses a linear layout, and not only the PanelContainment? 
> > another concern i have is that the drag enter doesn't look at what is being \
> > dragged in. it should probably be limited to things we can accept (URLs, applets \
> > ..) 
> > as for the dragLeave event issue ... one hack that *might* work is to do a \
> > QCoreApplication::postEvent; when a drag starts it creates an inner event loop \
> > and i'll bet that QCoreApplet::postEvent uses the application global event, \
> > meaning that when the drag even loop goes away we'll get the posted event and can \
> > do a check for the spacer then. a bit tricksy, but it might work =)

was esitant to do so for the separation view scene stuff, aaanyways
in the current one the creation of the spacer behaves far better (also the dragleave \
issue seems to be magically solved, dragleave on the view gets called, unlike the \
containment one)

the problem remaining is, now that i moved the spacer thinghy outside the \
contanment... how i forward the drop event on it?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/227/#review224
-----------------------------------------------------------


On 2008-10-20 06:05:11, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/227/
> -----------------------------------------------------------
> 
> (Updated 2008-10-20 06:05:11)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> when dropping an applet from the applet browser a big empty area appears in between \
> the two applets most near the mouse cursor, making it easier to hit an empty area \
> of the panel with drag and drop. 
> seems to work quite good, only problem that don't really know how to address is \
> that pressing esc with the cursor in the panel doesn't dragleave won't get called, \
> so the empty space stays here 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.h
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/227/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]