[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fixes crash on programgrouping with startup tasks
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-10-07 15:00:18
Message-ID: 20081007150018.30151.84835 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/219/#review218
-----------------------------------------------------------

Ship it!


sounds good, grouping starting tasks probably wouldn't make sense anyways

- Marco


On 2008-10-07 03:25:17, Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/219/
> -----------------------------------------------------------
> 
> (Updated 2008-10-07 03:25:17)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> This should fix the crash in programgroupingstrategy as described by Sebastian Kügler.
> The problem was that the strategy had access to startup tasks via the rootGroup.
> I shortly checked all other strategies but this shouldn't be a problem there.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/219/diff
> 
> 
> Testing
> -------
> 
> i just tried it shortly, should work.
> 
> 
> Thanks,
> 
> Christian
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread]