From kde-panel-devel  Tue Sep 30 16:20:09 2008
From: "Marco Martin" <notmart () gmail ! com>
Date: Tue, 30 Sep 2008 16:20:09 +0000
To: kde-panel-devel
Subject: Re: Review Request: Retrieve own user icon in Twitter
Message-Id: <20080930162009.29614.76577 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=122279166027856



> On 2008-09-30 09:01:10, Aaron Seigo wrote:
> > /trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.cpp, line 123
> > <http://reviewboard.vidsolbach.de/r/205/diff/1/?file=1145#file1145line123>
> >
> >     should be on a line by itself

i usually do those ugly things when writing/testing, and then whe i foget one alive oh the embrassment, lol :)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/205/#review209
-----------------------------------------------------------


On 2008-09-27 13:03:21, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/205/
> -----------------------------------------------------------
> 
> (Updated 2008-09-27 13:03:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This adds an option in the timelineservice to downloadan user profile. used to retrieve the own user icon when there are no own tweets in the recent ones
> don't like too much how it's done in the applet part, hmm, no idea how to make it more clean :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.h
>   /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.cpp
>   /trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.h
>   /trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.cpp
>   /trunk/KDE/kdeplasma-addons/dataengines/twitter/twitterengine.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/205/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel