From kde-panel-devel  Tue Sep 30 15:56:23 2008
From: "Aaron Seigo" <aseigo () kde ! org>
Date: Tue, 30 Sep 2008 15:56:23 +0000
To: kde-panel-devel
Subject: Re: Review Request: animate icon hover effect of Plasma::Icon
Message-Id: <20080930155623.27649.8455 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=122279023425265


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/202/#review207
-----------------------------------------------------------

Ship it!


code duplication is unfortunate, but seems to be the only option here atm.

please reformat the code to fit our coding style, though. =)

- Aaron


On None, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/202/
> -----------------------------------------------------------
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> since it's done over and over again blending of two pixmaps in an animation and usually not in the correct way, just a pixmap superimposed onto another (cashew, taskbar, buttons) perhaps a function that does that could be very handy.
> KFileItemDelegate::Private::transition() seems to do exactly what is needed (i think also in the fastest way available today? ehi great fredrikh:)
> it's a bit of a dumb copy of the method into paintutils, but i don't see prettier ways to do that...
> now it's used by Plasma::icon (perhaps caching the pixmap in result could make the performance better?)
> if it's ok would convert other things to use that
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/paintutils.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/paintutils.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/icon.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/202/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel