From kde-panel-devel  Sun Sep 28 13:41:57 2008
From: =?utf-8?q?Petri_Damst=C3=A9n?= <petri.damsten () gmail ! com>
Date: Sun, 28 Sep 2008 13:41:57 +0000
To: kde-panel-devel
Subject: Re: Review Request: Scripting support for comic
Message-Id: <20080928134157.27536.80493 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=122260936830340


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/203/
-----------------------------------------------------------

(Updated 2008-09-28 06:41:57.469019)


Review request for Plasma.


Summary
-------

Kross scripting support for comic

* Added missing files
* Use package in script loading

* fix crash with cached provider


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/comic/CMakeLists.txt
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.h
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp
  /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h
  /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp
  /trunk/KDE/kdeplasma-addons/applets/comic/pluginmanager.h
  /trunk/KDE/kdeplasma-addons/applets/comic/pluginmanager.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/CMakeLists.txt
  /trunk/KDE/kdeplasma-addons/dataengines/comic/boondocksprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/cachedprovider.h
  /trunk/KDE/kdeplasma-addons/dataengines/comic/cachedprovider.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/cadprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/calvinandhobbesprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comic.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comic_package.h
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comic_package.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comic_package_plugin.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comicprovider.h
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comicprovider.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comicproviderkross.h
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comicproviderkross.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comicproviderwrapper.h
  /trunk/KDE/kdeplasma-addons/dataengines/comic/comicproviderwrapper.cpp
  /trunk/KDE/kdeplasma-addons/dataengines/comic/dilbertprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/doonesburyprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/extralifeprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/garfieldprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/malvadosprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/nichtlustigprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/osnewsprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/phdprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/plasma-dataengine-comic.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/plasma-packagestructure-comic.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/plasma_comicprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/shithappensprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/snoopyprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/unshelvedprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/userfriendlyprovider.desktop
  /trunk/KDE/kdeplasma-addons/dataengines/comic/xkcdprovider.desktop

Diff: http://reviewboard.vidsolbach.de/r/203/diff


Testing
-------

Python dilbert works:
http://kotisivu.lumonetti.fi/damu0/kde/dilbert_x.comic

* updated


Thanks,

Petri

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel