[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: switch from complete to popup on panel resize
From:       Marco Martin <notmart () gmail ! com>
Date:       2008-09-17 11:42:24
Message-ID: 200809171342.25060.notmart () gmail ! com
[Download RAW message or body]

On Wednesday 17 September 2008, Aaron Seigo wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/194/#review201
> -----------------------------------------------------------
>
> Ship it!
>
>
> holy crap, you're churning out more patches than me this week!
>
> (if only i had less paperwork to wade through yesterday and today; just
> means i have to work 2x as hard to overtake you by week's end ;)
oh, don't fear, in upcoming times will be quite busy, so you will have all 
your revenge ehehe :)

Cheers,
Marco Martin

> - Aaron
>
> On 2008-09-16 14:11:35, Marco Martin wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.vidsolbach.de/r/194/
> > -----------------------------------------------------------
> >
> > (Updated 2008-09-16 14:11:35)
> >
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > A vertical panel for instance is a containment constrained horizontally
> > and not vertically, so popupapplets displays the content in icons. it can
> > happen however that the panel size would be big enough to make the applet
> > content fit, so this patch makes the rapresentation switch from icon to
> > complete and back when the panel is resized and there is enough room. an
> > use would be for instance with very big autohide panels (think about
> > yakuake on plasmoids:)
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
> >
> > Diff: http://reviewboard.vidsolbach.de/r/194/diff
> >
> >
> > Testing
> > -------
> >
> > tested in horizontal and vertical panels
> >
> >
> > Thanks,
> >
> > Marco


_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]