[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Moving m_time,
From:       "Rafa? Mi?ecki" <zajec5 () gmail ! com>
Date:       2008-09-05 14:59:55
Message-ID: 20080905145955.12611.52865 () vidsolbach ! de
[Download RAW message or body]



> On 2008-09-05 07:38:29, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h, lines \
> > 57-59 <http://reviewboard.vidsolbach.de/r/173/diff/2/?file=849#file849line57>
> > 
> > why do you need the time and date members?
> > 
> > moving m_prettyTimezone makes sense as all timezone handling moves into the lib, \
> > however does it need to be public?

Tool tip's mainText contains name of main timezone plus time and data in that \
timezone. So I need m_time and m_date for creating tool tip's mainText. \
m_prettyTimezone will be moved to private after removing it from digital clock.


- Rafa?


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/173/#review157
-----------------------------------------------------------


On 2008-09-05 01:35:02, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/173/
> -----------------------------------------------------------
> 
> (Updated 2008-09-05 01:35:02)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> To move standarised tooltip from digital clock into libplasmaclock I need to have \
> access to theses variables inside libplasmaclock. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.h
> /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.h
> /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h
> /trunk/KDE/kdeplasma-addons/applets/binary-clock/binaryclock.h
> /trunk/KDE/kdeplasma-addons/applets/binary-clock/binaryclock.cpp
> /trunk/KDE/kdeplasma-addons/applets/fuzzy-clock/fuzzyClock.h
> 
> Diff: http://reviewboard.vidsolbach.de/r/173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rafa?
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]