[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Autohide options for PanelController
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-09-03 17:26:25
Message-ID: 20080903172625.20940.14927 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/166/
-----------------------------------------------------------

(Updated 2008-09-03 10:26:25.240533)


Review request for Plasma.


Summary
-------

this patch, really work in progress, adds a submenu in PanelController made with a \
Plasma::Dialog containing tha aligning options and the autohide/unerwindows options. \
done in a submenu because we were really at the limit for a 1024 (iirc hig says it \
still have to go well in 800x600?) so put less frequent actions here. Not sure about \
where put the panel alignment btw (so didn't sped much time on it, just moved)

Update: works as expected, seem to not have misbehavings, look is still awful, that \
buttons needs to be themed with the plasma buttons graphics i think, but well, in a \
second moment :)


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp

Diff: http://reviewboard.vidsolbach.de/r/166/diff


Testing
-------


Screenshots
-----------

dialog open
  http://reviewboard.vidsolbach.de/r/166/s/53/
last version
  http://reviewboard.vidsolbach.de/r/166/s/55/


Thanks,

Marco

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]