[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Plasma wallpaper painting inconsistency
From: "Benoit Jacob" <jacob.benoit.1 () gmail ! com>
Date: 2008-09-03 4:04:36
Message-ID: d9f848520809022104u10b313cw6e5015549adb425 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Yes, seems fixed. More specifically the debug output now is:
.....
plasma(8143) Mandelbrot::paint: recompute QRect(640,0
160x100)
plasma(8143) Mandelbrot::paint: repaint QRectF(637,0
166x103)
plasma(8143) Mandelbrot::paint: recompute QRect(800,0
160x100)
plasma(8143) Mandelbrot::paint: repaint QRectF(797,0
166x103)
plasma(8143) Mandelbrot::paint: recompute QRect(960,0
160x100)
plasma(8143) Mandelbrot::paint: repaint QRectF(957,0
166x103)
plasma(8143) Mandelbrot::paint: recompute QRect(1120,0
160x100)
plasma(8143) Mandelbrot::paint: repaint QRectF(1117,0
163x103)
plasma(8143) Mandelbrot::paint: recompute QRect(1120,100
160x100)
plasma(8143) Mandelbrot::paint: repaint QRectF(1117,97
163x106)
plasma(8143) Mandelbrot::paint: recompute QRect(1120,200
160x100)
plasma(8143) Mandelbrot::paint: repaint QRectF(1117,197
163x106)
plasma(8143) Mandelbrot::paint: recompute QRect(1120,300
160x100)
plasma(8143) Mandelbrot::paint: repaint QRectF(1117,297
163x106)
.....
So the actually repainted rect is only slightly larger than what is being
asked for. A margin of 3 or 6 pixels seems to still be added. Normal
behavior?
There still are repainting glitches, but it'll be time to discuss these when
i'll have committed.
Cheers,
Benoit
2008/9/3 Aaron J. Seigo <aseigo@kde.org>
> On Tuesday 02 September 2008, Aaron J. Seigo wrote:
> > On Tuesday 02 September 2008, Benoit Jacob wrote:
> > > See, the paint() function is always called with exposedRect equal to
> the
> > > whole screed, regardless of the parameter passed to update().
> >
> > this is a bug in Applet::paint; not sure when it was introduced, but it's
> a
> > pretty big fubar. =/ i'm working on fixing it right now...
>
> can you svn up and let me know if it's better now? =)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
[Attachment #5 (text/html)]
<div dir="ltr">Yes, seems fixed. More specifically the debug output now \
is:<br><br>.....<br>plasma(8143) Mandelbrot::paint: recompute QRect(640,0 \
160x100) \
<br>plasma(8143) Mandelbrot::paint: repaint QRectF(637,0 \
166x103) \
<br> plasma(8143) Mandelbrot::paint: recompute QRect(800,0 \
160x100) \
<br>plasma(8143) Mandelbrot::paint: repaint QRectF(797,0 \
166x103) \
<br>plasma(8143) Mandelbrot::paint: recompute QRect(960,0 \
160x100) \
<br> plasma(8143) Mandelbrot::paint: repaint QRectF(957,0 \
166x103) \
<br>plasma(8143) Mandelbrot::paint: recompute QRect(1120,0 \
160x100) \
<br>plasma(8143) Mandelbrot::paint: repaint QRectF(1117,0 \
163x103) \
<br> plasma(8143) Mandelbrot::paint: recompute QRect(1120,100 \
160x100) \
<br>plasma(8143) Mandelbrot::paint: repaint QRectF(1117,97 \
163x106) \
<br>plasma(8143) Mandelbrot::paint: recompute QRect(1120,200 \
160x100) \
<br> plasma(8143) Mandelbrot::paint: repaint QRectF(1117,197 \
163x106) \
<br>plasma(8143) Mandelbrot::paint: recompute QRect(1120,300 \
160x100) \
<br>plasma(8143) Mandelbrot::paint: repaint QRectF(1117,297 \
163x106) \
<br>
.....<br><br>So the actually repainted rect is only slightly larger than what is \
being asked for. A margin of 3 or 6 pixels seems to still be added. Normal \
behavior?<br><br>There still are repainting glitches, but it'll be time to \
discuss these when i'll have committed.<br> <br>Cheers,<br>Benoit<br><br><div \
class="gmail_quote">2008/9/3 Aaron J. Seigo <span dir="ltr"><<a \
href="mailto:aseigo@kde.org">aseigo@kde.org</a>></span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d">On Tuesday 02 September 2008, \
Aaron J. Seigo wrote:<br> > On Tuesday 02 September 2008, Benoit Jacob wrote:<br>
> > See, the paint() function is always called with exposedRect equal to \
the<br> > > whole screed, regardless of the parameter passed to update().<br>
><br>
> this is a bug in Applet::paint; not sure when it was introduced, but it's \
a<br> > pretty big fubar. =/ i'm working on fixing it right now...<br>
<br>
</div>can you svn up and let me know if it's better now? =)<br>
<div><div></div><div class="Wj3C7c"><br>
--<br>
Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Trolltech<br>
<br>
</div></div><br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br></div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic