[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [patch] QHttp and QFtp forbidden in KDE
From:       Thiago Macieira <thiago () kde ! org>
Date:       2008-08-29 10:57:16
Message-ID: 200808291257.16974.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Those two classes are not allowed in KDE code. They won't follow the KDE 
settings, so using KIO is mandatory.

The attached patch will accomplish this by causing any code using them to fail 
to compile.

I will commit it next week. I know that the twitter plasmoid is using QHttp 
and will thus break.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358


["0001-Cause-code-using-QHttp-and-QFtp-to-fail-to-compile.patch" (text/x-patch)]

From 7e23865b55b25d895eeb026d41e044057d214709 Mon Sep 17 00:00:00 2001
From: Thiago Macieira <thiago.macieira@trolltech.com>
Date: Fri, 29 Aug 2008 12:56:44 +0200
Subject: [PATCH] Cause code using QHttp and QFtp to fail to compile

---
 cmake/modules/FindKDE4Internal.cmake |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/cmake/modules/FindKDE4Internal.cmake b/cmake/modules/FindKDE4Internal.cmake
index 3025906..85608ab 100644
--- a/cmake/modules/FindKDE4Internal.cmake
+++ b/cmake/modules/FindKDE4Internal.cmake
@@ -275,6 +275,10 @@ set(QT_MIN_VERSION "4.4.0")
 #this line includes FindQt4.cmake, which searches the Qt library and headers
 find_package(Qt4 ${_REQ_STRING_KDE4})
 
+# Disable portions of Qt that we don't want in KDE 4 applications and
+# libraries
+add_definitions(-DQT_NO_HTTP -DQT_NO_FTP)
+
 # automoc4 (from kdesupport) is now required, Alex
 find_package(Automoc4 ${_REQ_STRING_KDE4})
 
-- 
1.6.0.rc2.1.g147157


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]