--===============0793344238==
Content-Type: multipart/signed;
  boundary="nextPart1418433.3c1B2g6TLE";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1418433.3c1B2g6TLE
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Le Monday 25 August 2008, Aaron J. Seigo a =E9crit :
> On Monday 25 August 2008, Gerhard Gappmeier wrote:
> > Hi Aaron,
> >
> > I just took a quick look at the code.
> >
> > If noticed that readNumberFromFile() and readStringFromFile() are using
> > fopen to access the file.
>
> the only place that those are used is actually commented out right now;
> they are used for statistics liket tx/rx/etc. that needs to be ported to
> ksysguard or dropped.

I'd say they'd better be dropped for now (I mean they're unused ATM, and=20
available in the history if we need to bring them back later).

> personally, i'm not sure we need those stats here and that they may be
> better served by either being in another engine or by being separate
> sources in the same engine.

Well, it'd probably make sense to have them in a more "ksysguard like" engi=
ne.=20
In fact if they're removed from this engine it'd probably make sense to als=
o=20
increase the minimumPollingInterval (twice a second right now, it seems a b=
it=20
high to me).

Regards.
=2D-=20
K=E9vin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le ma=EEtre sans disciple, Ni le disciple sans ma=EEtre,
Ne font reculer l'ignorance."

--nextPart1418433.3c1B2g6TLE
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkizLLQACgkQB0u7y43syeJRkACgog4PRcpVgg6ud8jL+kEc5sgX
W5MAn1HlN6W8OpYJpWD+kwAkJJ0ZC04l
=Sxe2
-----END PGP SIGNATURE-----

--nextPart1418433.3c1B2g6TLE--

--===============0793344238==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============0793344238==--