From kde-panel-devel  Sun Aug 24 12:52:36 2008
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Sun, 24 Aug 2008 12:52:36 +0000
To: kde-panel-devel
Subject: Re: System tray rewrite ready for review
Message-Id: <200808240652.36983.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=121958233610510
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============2064885843=="

--===============2064885843==
Content-Type: multipart/signed;
  boundary="nextPart4476408.b7dWZ3V8qM";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart4476408.b7dWZ3V8qM
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sunday 24 August 2008, Jason Stubbs wrote:
> Aaron J. Seigo wrote:
> > On Sunday 17 August 2008, Jason Stubbs wrote:
> >> I'm fairly happy with the state of the rewrite and so am requesting th=
at
> >> it be reviewed for moving into trunk/kdebase. There's not much that it
> >> doesn't fix and not much work left to do, but no show stoppers as far =
as
> >> I know.
> >
> > some thoughts/comments:
> >
> > * i wonder if the core/ code shouldn't actually become a dataengine at
> > some point. for now it's ok and probably good to keep it internal to the
> > applet until we're sure about the API and structure
>
> Is passing QGraphicsWidget*s from a data engine possible? If so, then it

it's *possible* but in this case i don't think it would be pretty. perhaps =
we=20
should instead aim for providing the new icons via an engine (as they are=20
primarily data) and just keep the current fd.o based one as is.

> > i'm running the new tray now and the first time i started it, it showed
> > no icons.. it's the right size, just no icons showing. the debug output
> > shows that the FDO icons are being detected, embeded, etc:
> >
> > plasma(13085) SystemTray::FDO::GraphicsWidget::paint: embedding into
> > PanelView ( 75497651 )
> >
> > but nothing is actually visible =3D/ looks like a similar issue to Sebas
> > perhaps, and i'll see if logging out/in helps any.
>
> I really dislike temperamental bugs. I'll try scouring through again and
> look for size/placement issues this time. Why can't bugs just occur
> every single time? :(

it was because of the restarting of the timer in the paint event; i fixed i=
t a=20
few days back now and it's working reliably for me now.

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


--nextPart4476408.b7dWZ3V8qM
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkixWZQACgkQ1rcusafx20OrYQCdG8rpe4Rc089cWUqVFrHl2Kp8
rAAAnjJvmUOgmiiELNLRXj5jSGeGs01V
=3zix
-----END PGP SIGNATURE-----

--nextPart4476408.b7dWZ3V8qM--

--===============2064885843==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============2064885843==--