[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma themed monitor of background dialog
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-08-23 21:17:31
Message-ID: 20080823211731.7185.35258 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/140/
-----------------------------------------------------------

(Updated 2008-08-23 14:17:31.646022)


Review request for Plasma.


Summary
-------

The monitor of the background dialog is a simple pixmap of a 4:3 monitor that gets \
scaled in the case the monitor has a different aspect ratio see \
http://img95.imageshack.us/img95/6236/snapshot2uu9.png multiple images could be dome \
but while most of monitors are 4:3 or 16:10 who knows in the future devices what \
funny resolutions would have :D andevery one should also be rotated, for monitors \
that supports rotation so i gave a try with panelsvg since doesn't take much \
effort/code and the result seems nice (and themable too:)) the graphics are still \
temporary, it's just the standard applet background with the foot of the oxygen \
monitor icon, but i think looks more nice already :)


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/monitor.svgz
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/wallpaperpreview.h
  /trunk/KDE/kdebase/workspace/plasma/shells/desktop/wallpaperpreview.cpp

Diff: http://reviewboard.vidsolbach.de/r/140/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.vidsolbach.de/r/140/s/37/
deformed svg
  http://reviewboard.vidsolbach.de/r/140/s/38/


Thanks,

Marco

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]