[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma themed monitor of background dialog
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-08-23 20:36:29
Message-ID: 20080823203629.6145.62647 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/140/#review131
-----------------------------------------------------------


i wonder if this couldn't be done with the actual monitor.svg scalable icon? might \
have even nicer results? 

if not, i like how this looks better than what we currently have. i'm a little \
concerned about adding an svg to the theme just for this though ...

as an aside, this dialog needs some love before 4.2 (it's on my "things to make sure \
get love" list); e.g. the word Containment should not appear anywhere, we need to \
offer an editable combo for the name of the activity, the widgets need to be laid out \
according to the HIG, etc.. nothing really to do with this patch, though =)

- Aaron


On 2008-08-23 12:28:23, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/140/
> -----------------------------------------------------------
> 
> (Updated 2008-08-23 12:28:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The monitor of the background dialog is a simple pixmap of a 4:3 monitor that gets \
> scaled in the case the monitor has a different aspect ratio see \
> http://img95.imageshack.us/img95/6236/snapshot2uu9.png multiple images could be \
> dome but while most of monitors are 4:3 or 16:10 who knows in the future devices \
> what funny resolutions would have :D andevery one should also be rotated, for \
> monitors that supports rotation so i gave a try with panelsvg since doesn't take \
> much effort/code and the result seems nice (and themable too:)) the graphics are \
> still temporary, it's just the standard applet background with the foot of the \
> oxygen monitor icon, but i think looks more nice already :) 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/monitor.svgz
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/wallpaperpreview.h
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/wallpaperpreview.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/140/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.vidsolbach.de/r/140/s/37/
> 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]