[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Wallpaper plugins
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-08-23 14:25:25
Message-ID: 200808230825.31584.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 23 August 2008, Petri Damstén wrote:
> On Saturday 23 August 2008 01:05:38 Aaron J. Seigo wrote:
> > > 2. Was wallpaper config save remove intentional?
> >
> > yes; i moved it to Containment::save
>
> But, doesn't that just save the wallpaper config to old containment. This
> code was there to copy wallpaper config to new containment.

what happens in the code is:

* old containment save settings: old->save(containmentConfig);
* new containment reads those settings: c->restore(containmentConfig);
* we switch config objects: containmentConfig = c->config()
* new containment saves its settings: c->save(containmentConfig);
* config sync requested: corona->requestConfigSync();

so by putting the wallpaper saving into Containment::save, not only does it fix 
a potential problem when we export layouts, but it allows the above to work as 
well.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]