[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: KDE/kdebase/apps/plasma/applets/folderview
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-07-31 20:04:29
Message-ID: 200807311404.29813.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 31 July 2008, Carlo Segato wrote:
> SVN commit 840247 by segato:
>
> fix titletext on windows
>
>  M  +4 -0      folderview.cpp
>
>
> --- trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
> #840246:840247 @@ -771,7 +771,11 @@
>      if (m_url == KUrl("desktop:/")) {
>          titleText = i18n("Desktop"); //FIXME: 4.2 make it "Desktop Folder;
>      } else if (m_url.isLocalFile() &&
> m_url.path().startsWith(KUrl("~").path())) { +#ifndef Q_WS_WIN
>          titleText = m_url.path().replace(KUrl("~").path(), i18n("Home"));
> +#else
> +        titleText = m_url.path().replace(QDir::homePath(), i18n("Home"));
> +#endif
>      } else {
>          titleText = m_url.pathOrUrl();
>      }

just to note: 

this is exactly the kind of platform specific #ifdef'ing i do not want to see 
in plasma code.

there are platform neutral ways to do these things; if you're unsure, ask first 
before putting in any platorm specific ifdef's. thanks =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]