[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Extender api review, round 2
From:       Rob Scheepmaker <r.scheepmaker () student ! utwente ! nl>
Date:       2008-07-29 16:57:01
Message-ID: 200807291857.01177.r.scheepmaker () student ! utwente ! nl
[Download RAW message or body]

On Tuesday 29 July 2008 18:47:28 Dmitry Suzdalev wrote:
> On Tuesday 29 July 2008 20:38:55 Aaron J. Seigo wrote:
> > it's looking better and better! =)
>
> True! :)
>
> I spotted two things:
>
> 1. (minor) Add 'explicit' to constructor of Extender class?

you're right.

> 2. setIsPopup/isPopup apidox don't say anything about what behavior is
> default! To popup or not to popup? :)
>
> I always miss this in APIs - a lot of setter functions specify what will be
> done, but fail to specify what is the default behavior.
> libplasma has a lot such issues too :-P. Or at least had them when i last
> looked.

Right, I'll walk true the apidox and make sure default behavior is specified everywhere.

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]