[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add absolute file path support to PackageStructure
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-07-29 1:14:20
Message-ID: 20080729011420.32254.19738 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/99/#review102
-----------------------------------------------------------

Ship it!


good work =)

- Aaron


On None, Joe Burns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/99/
> -----------------------------------------------------------
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> PackageStructure::load will now take an absolute filepath and load the structure from there.
> 
> Edit: now it shouldn't break when passed a remote path.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/99/diff
> 
> 
> Testing
> -------
> 
> Loaded a packagestructure file into my soc project plasmagik.
> 
> Edit: test loading a .packagestructure from websvn and also a local .packagestructure
> 
> 
> Thanks,
> 
> Joe
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic