[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma::Pushbutton  with svg theming
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-07-28 21:15:38
Message-ID: 20080728211538.29254.96439 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/90/#review101
-----------------------------------------------------------

Ship it!


looks good. i see you had to update it to keep up with api additions, so let's get \
this into svn so you don't face more bitrot induced management =)


/trunk/KDE/kdebase/workspace/libs/plasma/widgets/pushbutton.cpp
<http://reviewboard.vidsolbach.de/r/90/#comment72>

    if you do new Plasma::PanelSvg(this) you don't need to delete it manually later. 
    
    (also, you're already in the Plasma namespace here, so technically you don't need \
to do Plasma::PanelSvg either, just PanelSvg; but if you like typing Plasma a lot ... \
go for it ;)


- Aaron


On 2008-07-28 12:35:52, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/90/
> -----------------------------------------------------------
> 
> (Updated 2008-07-28 12:35:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is a first version of svg theming in proxywidgets here is the button
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/libs/plasma/widgets/pushbutton.h
> /trunk/KDE/kdebase/workspace/libs/plasma/widgets/pushbutton.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/90/diff
> 
> 
> Testing
> -------
> 
> calculator widget for buttons with text
> kolourpicker for buttons with icons
> 
> 
> Screenshots
> -----------
> 
> calculator
> http://reviewboard.vidsolbach.de/r/90/s/28/
> 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]