From kde-panel-devel  Sun Jul 27 21:54:56 2008
From: "Aaron Seigo" <aseigo () kde ! org>
Date: Sun, 27 Jul 2008 21:54:56 +0000
To: kde-panel-devel
Subject: Re: Review Request: PopupApplet : add some stuffs
Message-Id: <20080727215456.18756.43568 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=121719573309161


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/109/#review100
-----------------------------------------------------------

Ship it!


i think we're there! good work ... one step closer to world domination ;)



/trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
<http://reviewboard.vidsolbach.de/r/109/#comment69>

    this TODO is no longer relevant since the code will now work perfectly =)



/trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
<http://reviewboard.vidsolbach.de/r/109/#comment71>

    not really critical, but if we added a Plasma::InvalidAspectRatioMode = - 1 to plasma.h, we could get rid of the bool here =)



/trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
<http://reviewboard.vidsolbach.de/r/109/#comment70>

    this is fine, but you could also have written this as:
    
    QGraphicsView *view = new QGraphicsView(scene, d->dialog);


- Aaron


On 2008-07-27 13:26:35, Loic Marteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/109/
> -----------------------------------------------------------
> 
> (Updated 2008-07-27 13:26:35)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Here is a patch to adapt Device Notifier to use Plasma::PopupApplet.
> 
> I have add some timer stuff in popupApplet so we can say how time we want popup the applet in panel.
> 
> I have change a little the way popupApplet work on Desktop mode by using the same Plasma::dialog widget than we use in Panel Mode.
> Perhaps it is not a good idea ?!
> 
> If we prefer not using Plasma:Dialog in Desktop mode i have to found a correct way to use the plasma theme inside the proxyWidget, which is not the case in the actual code.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/109/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Loic
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel