[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: on the tabbar widget
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-07-27 16:09:59
Message-ID: 200807271010.00116.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 27 July 2008, Marco Martin wrote:
> On Sunday 27 July 2008 00:01:38 Aaron J. Seigo wrote:
> > On Saturday 26 July 2008, Marco Martin wrote:
> > > i would like to merge in libplasma as soon as possible, so it really
> > > needs a review, i'm really not sure about several things, like:
> > > what level of wrapping should be provided by the tabbar proxywidget?
> > > now it wraps the addtab functions and the signal, too much?
> >
> > it looks ok.. a TabWidget is pretty complex, so i don't see any realistic
> > shortcuts here.
> >
> > one thing i do wonder about, though, is whether or not we need/want both
> > a TabBar and a TabWidget; i wonder if we could get away with just a
> > TabWidget which behaves essentially like a TabBar if a null pointer is
> > passed in for the content of a tab? would keep the number of classes
> > down... what do you think? (i'm on the fence myself =)
>
> soo, the tabwidget that wraps the addpage insertpage and removepage of the
> tabbar, when addpage has always a nullpointer bebaves like a tabbar and
> nativewidget returns the qtabbar (soo the tabbar proxywidget could even be
> avoided) ...
> hmm don't know seems a bit frankenstein :) btw i'll try.

yes, it's a bit frankenstein indeed, but it also gives you a sort of 
"principle of least surprise": you either give it the widgets to manage, or 
you don't and you manage them yourself.

from the outside, it's pretty obvious. on the inside it'll be a bit 
complicatd. but that's very Plasma, isn't it? ;)

> another thing on what i was unsure at the moment on page change there isa
> neat sliding animation that doesn't seem to take too much cpu, but it has a
> really ugly flickering problem with proxywidgets (because of
> http://trolltech.com/developer/task-tracker/index_html?id=220488&method=ent
>ry since enables clipping when the anim is running)
> i was unsure to leave it looking bad until (and if) the qt bug is fixed or
> simply renouncing to the cute effect.

perhaps leave the code in, but #ifdef 0'd out with a TODO note to track that 
Qt bug so we can re-enable it when it is fixed.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]