[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: PopupApplet : add some stuffs
From:       "Loic Marteau" <loic.marteau () gmail ! com>
Date:       2008-07-27 14:20:45
Message-ID: 20080727142045.6366.45448 () vidsolbach ! de
[Download RAW message or body]



> On 2008-07-26 18:06:10, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h, lines 48-49
> > <http://reviewboard.vidsolbach.de/r/109/diff/3/?file=537#file537line48>
> > 
> > this change the pattern from on demand creation of the widget to creating and \
> > registering the widget at applet startup. this is not going to work very well and \
> > make delayed loading of expensive widgets much more difficult. 
> > instead, i'd simply suggest a pair of methods, either of which can be \
> > reimplemented: 
> > virtual QWidget *widget();
> > virtual QGraphicsWidget *graphicsWidget();
> > 
> > in the default implementation, both would return a null pointer.

Here is an update who add
virtual QGraphicsWidget *graphicsWidget();

For the moment it use a QGraphicsView inside Plasma::Dialog (QWidget)

Patch for calculator will follow.

Missing stuff
1) plasma theme is not applied with widget inside a proxy in desktop mode (the same \
as the actual code) 2) plasma theme is not applied with qgraphicswidget inside the \
graphicsview in popup mode 3) Perhaps we can add a GraphicsDialog to Plasma so we \
only use qgraphicsstuff for qgraphicswidget ? If we have to can it be added in a \
second time ? 


- Loic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/109/#review92
-----------------------------------------------------------


On 2008-07-27 07:19:54, Loic Marteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/109/
> -----------------------------------------------------------
> 
> (Updated 2008-07-27 07:19:54)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Here is a patch to adapt Device Notifier to use Plasma::PopupApplet.
> 
> I have add some timer stuff in popupApplet so we can say how time we want popup the \
> applet in panel. 
> I have change a little the way popupApplet work on Desktop mode by using the same \
> Plasma::dialog widget than we use in Panel Mode. Perhaps it is not a good idea ?!
> 
> If we prefer not using Plasma:Dialog in Desktop mode i have to found a correct way \
> to use the plasma theme inside the proxyWidget, which is not the case in the actual \
> code. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
> /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/109/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Loic
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]