[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Adapt Device Notifier to PopupApplet
From:       "Loic Marteau" <loic.marteau () gmail ! com>
Date:       2008-07-27 9:51:28
Message-ID: 20080727095128.4537.98276 () vidsolbach ! de
[Download RAW message or body]



> On 2008-07-26 18:06:10, Aaron Seigo wrote:
> > besides the other comments below, this patch seems to be showing the \
> > QGraphicsWidget on the canvas and doesn't show it in a popup ... which is the \
> > entire point of this class. 
> > by "should also support a QGraphicsWidget" what is meant is this: it should be \
> > possible to associate a QGraphicsWidget as the popup, so that when in a Planar or \
> > MediaCenter form factor is shows the QGraphicsWidget as the content of the \
> > applet, and when in a Vertical or Horizontal form factor it shows an icon for the \
> > applet and puts the QGrahpicsWidget in a QGrahpicsView in a Plasma::Dialog. 

In fact for the moment it directly draws the QGW itself as a popup but the result is \
not good. I was lacking knowledge to deal with this quickly and wanted to wait some \
comment for the rest of the draft before.

I will take care of your recommendations

is it better to add a QGraphicsView inside the Plasma::Dialog (which is in fact a \
QWidget) or directly provide a Plasma::GraphicsDialog so we can use only \
QGraphicsStuff for that ?


> On 2008-07-26 18:06:10, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h, line 60
> > <http://reviewboard.vidsolbach.de/r/109/diff/3/?file=537#file537line60>
> > 
> > the method name is not descriptive; and it should be in the private class.

onDisplayTimeExpired ?


- Loic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/109/#review92
-----------------------------------------------------------


On 2008-07-26 17:21:22, Loic Marteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/109/
> -----------------------------------------------------------
> 
> (Updated 2008-07-26 17:21:22)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Here is a patch to adapt Device Notifier to use Plasma::PopupApplet.
> 
> I have add some timer stuff in popupApplet so we can say how time we want popup the \
> applet in panel. 
> I have change a little the way popupApplet work on Desktop mode by using the same \
> Plasma::dialog widget than we use in Panel Mode. Perhaps it is not a good idea ?!
> 
> If we prefer not using Plasma:Dialog in Desktop mode i have to found a correct way \
> to use the plasma theme inside the proxyWidget, which is not the case in the actual \
> code. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
> /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/109/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Loic
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]