[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: plasma setup mode with a button in the kcm
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-07-27 2:47:23
Message-ID: 20080727024723.1104.24997 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/111/#review93
-----------------------------------------------------------

Ship it!


my only concern would be that this makes it possible to pop up the screen saver \
without locking it, even if that is the user setting; the result would be that the \
user could be tricked into thinking the screensaver is fully activated (and the scree \
locked) when really it's just in setup mode.

i'd suggest putting some sort of visual notification on screen at some point to \
denote that the screen saver is in this special (and unlocking) mode

- Aaron


On 2008-07-26 19:37:39, Chani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/111/
> -----------------------------------------------------------
> 
> (Updated 2008-07-26 19:37:39)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> "setup mode" really means it starts lockprocess with plasma unlocked and active, \
> the unlock dialog suppressed, and free-unlocking on, so that the user can configure \
> their widgets and leave without entering their password (unless, of course, they \
> leave the computer alone long enough for it to lock). 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.h
> /trunk/KDE/kdebase/workspace/kcontrol/screensaver/scrnsave.cpp
> /trunk/KDE/kdebase/workspace/krunner/lock/lockprocess.h
> /trunk/KDE/kdebase/workspace/krunner/lock/lockprocess.cc
> /trunk/KDE/kdebase/workspace/krunner/lock/main.cc
> /trunk/KDE/kdebase/workspace/krunner/lock/plasma/main.cpp
> /trunk/KDE/kdebase/workspace/krunner/lock/plasma/plasmaapp.cpp
> /trunk/KDE/kdebase/workspace/krunner/org.kde.screensaver.xml
> /trunk/KDE/kdebase/workspace/krunner/saverengine.h
> /trunk/KDE/kdebase/workspace/krunner/saverengine.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/111/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]